Remove data field in the state aggregator if possible #17538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
benmoriceau
requested review from
alovew,
colesnodgrass,
gosusnp and
jdpgrailsdev
gosusnp
approved these changes
Oct 3, 2022
benmoriceau
added a commit
that referenced
this pull request
Oct 4, 2022
This reverts commit f45275e.
benmoriceau
added a commit
that referenced
this pull request
Oct 4, 2022
benmoriceau
added a commit
that referenced
this pull request
Oct 4, 2022
benmoriceau
added a commit
that referenced
this pull request
Oct 4, 2022
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
* Remove data field in the state aggregator if possible * Add comments * Add comment and update test
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
…ehq#17538)" (airbytehq#17583) This reverts commit f45275e.
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
…airbytehq#17538)" (airbytehq#17583)" (airbytehq#17584) This reverts commit 7180ac3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
remove the legacy state in the indiviual stream state since it is not needed. Do the same for global state.
Fix: https://github.com/airbytehq/oncall/issues/731